Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): add commitlint #564

Merged
merged 2 commits into from
Oct 17, 2022
Merged

feat(registry): add commitlint #564

merged 2 commits into from
Oct 17, 2022

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Oct 17, 2022

No description provided.

@dsully dsully changed the title feat: add commitlint feat(registry): add commitlint Oct 17, 2022
install = npm.packages {
"@commitlint/cli",
"@commitlint/config-conventional",
"commitlint-format-json",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to enable linter integrations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's supported by null-ls:

https://github.com/jose-elias-alvarez/null-ls.nvim/blob/main/doc/BUILTINS.md#commitlint

And all 3 of those packages are required for it to work.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool!

@williamboman williamboman merged commit d3abfbe into williamboman:main Oct 17, 2022
This was referenced Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants