Add support for the glint-language-server #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
12
to
13
| Pkg.Lang["typescript.glimmer"], | ||
| Pkg.Lang["javascript.glimmer"], |
There was a problem hiding this comment.
These language entries are meant for discovery purposes only, so these compound-like filetype names are not used elsewhere. I wonder if it'd be enough with "Handlebars" and "Glimmer"?
There was a problem hiding this comment.
ah, ok, probably -- I thought they needed to somehow map to a file's filetype
There was a problem hiding this comment.
The "programmatic" filetype mapping is governed by nvim-lspconfig for LSP servers! These language entries are really just arbitrary strings only used for presentational purposes, for now.
There was a problem hiding this comment.
My latest commit (on both repos) brought back
[mason-lspconfig.nvim] Server "glint" is not a valid entry in ensure_installed. Make sure to only provide lspconfig server names.
🤔
There was a problem hiding this comment.
ok, latest latest commit re-fixed this.
Co-authored-by: William Boman <william@redwill.se>
Co-authored-by: William Boman <william@redwill.se>
NullVoxPopuli
commented
Oct 23, 2022
This comment has been minimized.
This comment has been minimized.
This was referenced Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving as a draft for nowwhile I work on resolving: #583 (reply in thread)Accompanying PR: williamboman/mason-lspconfig.nvim#89
Need to get all the changes in the corresponding repos in place, test locally, and then I'll move these PRs out of draft