Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(golangci-lint): change installation method #969

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

FotiadisM
Copy link
Contributor

Thank you for your amazing work.

The team behind golangci-lint discourages installation using go install as stated in the official documentation.

This pull request changes the installation of golangci-lint to use the github manager instead of the go one.

@williamboman

This comment has been minimized.

Copy link
Owner

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I applied some stylistic changes to align this with other package installers

@williamboman williamboman merged commit 4772aec into williamboman:main Feb 6, 2023
This was referenced Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants