Create React App build fails to minify

[thevisioner]

I have created one project with Pts and it works really great, but when I run build script, it fails at minifying. I tried to compile library from source code, but I really don't know what exactly I need to change in configuration to make it work. Issue description at Create React App docs: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify

[williamngan]

Yes, I think the problem is that "create-react-app" uses UglifyJS, which doesn't support es6 modules.

I guess there're two options:

• Compile everything to es5 first and then minify. Probably will need the babel builtin-extend plugin or something similar for Array subclasses that were used in Pts

• Option 2: Use a different minify tool such as babili or uglify-es. Note that Pts uses Babili to minify, but there seems to a mobile webkit bug that prevents the minified code to run in mobile browser. Not sure if it's now fixed. FYI.

I was hoping we won't need to investigate a es5 compile workflow, but it seems like we'll need to. These build processes are really a big headache :)

If you get it to work in es5 minify, please post your suggestions here. Thanks!

[tofuness]

This will be fixed in create-react-app 2.x.

Roadmap: facebook/create-react-app#3618
Merge: facebook/create-react-app#3618

[williamngan]

Starting with v0.6.1, you should be able to make an es5 build in create-react-app by using:

import {Pt} from 'pts/dist/es5.js'; // use this for es5 build

Alternatively, you can use a newer companion tools such as neutrino.js instead of create-react-app. Take a look at the updated pts-react-example

[gaearon]

This is fixed in 2.0.
https://reactjs.org/blog/2018/10/01/create-react-app-v2.html

[williamngan]

Awesome! We'll test Pts using create-react-app 2.0 and update the docs soon. Thanks @gaearon