Skip to content

Commit 7772598

Browse files
committed
adding test for non-python nbextension
1 parent fe9c33d commit 7772598

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

notebook/tests/test_nbextensions.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
from traitlets.config.manager import BaseJSONConfigManager
3232

33+
3334
def touch(file, mtime=None):
3435
"""ensure a file exists, and set its modification time
3536
@@ -229,7 +230,7 @@ def test_quiet(self):
229230
stderr = StringIO()
230231
with patch.object(sys, 'stdout', stdout), \
231232
patch.object(sys, 'stderr', stderr):
232-
install_nbextension(self.src, logger=None)
233+
install_nbextension(self.src)
233234
self.assertEqual(stdout.getvalue(), '')
234235
self.assertEqual(stderr.getvalue(), '')
235236

@@ -435,5 +436,18 @@ def test_nbextensionpy_validate_bad(self):
435436
meta.update(require="bad-require")
436437

437438
warnings = validate_nbextension_python(meta, paths[0])
439+
self.assertNotEqual([], warnings, warnings)
440+
441+
def test_nbextension_validate(self):
442+
# Break the metadata (correct file will still be copied)
443+
self._inject_mock_extension('notebook')
444+
445+
install_nbextension_python('mockextension')
446+
enable_nbextension_python('mockextension', user=True)
447+
448+
warnings = validate_nbextension("_mockdestination/index")
449+
self.assertEqual([], warnings, warnings)
438450

451+
def test_nbextension_validate_bad(self):
452+
warnings = validate_nbextension("this-doesn't-exist")
439453
self.assertNotEqual([], warnings, warnings)

0 commit comments

Comments
 (0)