Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexing tests #332

Closed
willow-ahrens opened this issue Dec 5, 2023 · 2 comments
Closed

Add indexing tests #332

willow-ahrens opened this issue Dec 5, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed internal
Milestone

Comments

@willow-ahrens
Copy link
Collaborator

willow-ahrens commented Dec 5, 2023

We should make sure that common operations like A[3.14] and A[1.2:1.3] = 3 work by default on some finch formats https://willowahrens.io/Finch.jl/dev/guides/tensor_formats/

@willow-ahrens willow-ahrens added this to the v0.7.0 milestone Dec 5, 2023
@willow-ahrens willow-ahrens self-assigned this Dec 5, 2023
@willow-ahrens willow-ahrens modified the milestones: v0.7.0, v1.0 Feb 24, 2024
@willow-ahrens willow-ahrens removed their assignment Feb 27, 2024
@willow-ahrens
Copy link
Collaborator Author

willow-ahrens commented Feb 27, 2024

#337 #322 are both prereqs for tests to pass on many formats. That said, one could certainly add some tests here to see which formats support this.

@willow-ahrens willow-ahrens added help wanted Extra attention is needed internal labels May 8, 2024
@willow-ahrens willow-ahrens changed the title Add usability tests Add indexing tests May 15, 2024
@willow-ahrens willow-ahrens added the good first issue Good for newcomers label May 15, 2024
@willow-ahrens
Copy link
Collaborator Author

closing this, since its really more part of #337 #322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed internal
Projects
None yet
Development

No branches or pull requests

1 participant