Remove automatic injections

[buschtoens]

ember-useragent/addon/initializers/user-agent.js

Lines 7 to 14 in 32039b6

	export function initialize() {
	const application = arguments[1] || arguments[0];
	application.inject('controller', 'userAgent', 'service:userAgent');
	application.inject('component', 'userAgent', 'service:userAgent');
	application.inject('route', 'userAgent', 'service:userAgent');
	application.inject('view', 'userAgent', 'service:userAgent');
	}

Initializers and implicit automatic injections are becoming somewhat of an anit-pattern lately. I would recommend to remove them.

I just got bitten by this, because I was tying to inject a service with a different name (native/user-agent) as userAgent, but got ember-useragents service, as it's auto-injected before.

[snewcomer]

hi! Ping on this.

specifically, ember v4.0 will not work with this pattern.

emberjs/ember.js#19680

[buschtoens]

It is unquestionable, that these implicit injections will have to be removed eventually due to emberjs/ember.js#19680. Thus I recommend that anyone wanting to or currently using this addon, overrides https://github.com/willviles/ember-useragent/blob/master/app/initializers/user-agent.js in their own app with a no-op, like:

// app/initializers/user-agent.js
export function initialize() {}

This way the implicit injections are already disabled and you can't accidentally make use of them. Please note, that if you're making this change in an app that already uses ember-useragent, you should regression test it to ensure, you haven't already used these implicit injections accidentally.

[buschtoens]

As a way forward for ember-useragent itself, I would recommend to replace the application.inject(...) usages with custom macros, that raise a deprecation, when accessed. This allows users to discover and migrate all the callsites accidentally relying on these implicit injections bit by bit.

Optionally configuration could be included, to completely disable the injection, which should be recommended to be enabled by all new users. This way the breaking release can be delayed indefinitely, all the while being ready for Ember 4.0.

[snewcomer]

with custom macros, that raise a deprecation, when accessed. This allows users to discover and migrate all the callsites accidentally relying on these implicit injections bit by bit

I think we already did this for users in ember-source >= 3.26

emberjs/ember.js#19358

[buschtoens]

@snewcomer perfect, thanks! I wasn't sure any more and didn't re-read.

[willviles]

Released in 0.11.0. Thanks for all contributions!