API key search bug

[josephlewisnz]

Hey I've set up the module as normal including:

---
Name: algolia
After: silverstripe-algolia
---
SilverStripe\Core\Injector\Injector:
  Wilr\SilverStripe\Algolia\Service\AlgoliaService:
    properties:
      adminApiKey: "`ALGOLIA_ADMIN_API_KEY`"
      searchApiKey: "`ALGOLIA_SEARCH_API_KEY`"
      applicationId: "`ALGOLIA_SEARCH_APP_ID`"

I've noticed that when using search sever side eg.
$results = Injector::inst()->get(AlgoliaQuerier::class)->fetchResults(...)

I am getting an error with the fact that this method seems to use the adminApiKey rather than the expected searchApiKey

I am unsure if this is my misunderstanding of the setup or a bug.
My workaround was just to create a new "master" key on Algolia with all permissions enabled for both indexing and searching.

[wilr]

@josephlewisnz you're correct - it looks like fetchResult calls AlgoliaService::getClient() which uses the Admin API key by default. An enhancement would be to have AlgoliaService::getSearchClient() which uses the right key.