Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test for new/changed github-sourced packages fail #1227

Closed
philclifford opened this issue Dec 7, 2024 · 3 comments
Closed

CI test for new/changed github-sourced packages fail #1227

philclifford opened this issue Dec 7, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@philclifford
Copy link
Member

philclifford commented Dec 7, 2024

Mandatory CI tests on PRs for github-sourced apps seem to no longer be getting authenticated via token so all fail :-(

affects #1197 #1218 #1220 #1222

I think this was working for some time and recently started failing without the test yml having changed. Various attempts to change how/when the token is passed/presented (using 'export in the script', using 'env' to set the environment) have not worked.

Presumably github have changed something so the supplied CI token cannot be exported/used in a call out to an http GET header.

Originally posted by @philclifford in #1222 (comment)

@philclifford philclifford added bug Something isn't working help wanted Extra attention is needed labels Dec 7, 2024
@philclifford
Copy link
Member Author

I think we may need to add a repository secret for an API token for our CI tests to use to make authenticated API calls.

@silentJET85
Copy link
Contributor

I'm not 100% sure if it's the same issue, but I've been seeing similar errors when I do a deb-get update or try to install one of the github releases. I found that there's a write permission issue when it tries to save the cache file.
It looks like it may have started with commit 76a3018.

@philclifford
Copy link
Member Author

I think you've nailed it! Cherry-picking your fix seems to fix the CI failures.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants