Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Steps #2

Closed
LDprg opened this issue Jul 5, 2023 · 7 comments
Closed

Next Steps #2

LDprg opened this issue Jul 5, 2023 · 7 comments

Comments

@LDprg
Copy link
Member

LDprg commented Jul 5, 2023

So now we have created the repo. However what are the plans?
On the original Winapps Issue there were some open questions.

Here are some of them:

  • Reuse Code or Rewrite (or both)?
  • If rewrite which language?
  • How about the Issues and PRs on the original repo?
  • Maybe changing the Logo?
@LDprg LDprg closed this as completed Jul 5, 2023
@LDprg LDprg reopened this Jul 5, 2023
@freechelmi
Copy link
Contributor

I would say :

  • migrate the current main branch with history on our new develop branch
  • Select 10 or 20 relevant issue to import manually , and suggest the other to open on new trackers if needed
  • Ask people to resubmit their PR here after we tag the 0.1 and the test their PR on it ?
  • Or as you say start over in Rust or something else

@oskardotglobal
Copy link
Member

Some people were talking about replacing freerdp which is something we might consider for a rewrite

@LDprg
Copy link
Member Author

LDprg commented Jul 6, 2023

I would say :

  • migrate the current main branch with history on our new develop branch
  • Select 10 or 20 relevant issue to import manually , and suggest the other to open on new trackers if needed
  • Ask people to resubmit their PR here after we tag the 0.1 and the test their PR on it ?
  • Or as you say start over in Rust or something else

What if we do this and after we get a stable result start rewriting the software on another branch. This way we would solve the multiple fork issue. The only downside is that we would have to maintain 2 different codebases for some time.

@freechelmi
Copy link
Contributor

Yes That is what I would do :

  • Deliver a 0.1 shell on master based with all good contributions on forks and PR from 2021 on
  • Then Start another branch with some breaking changes

@oskardotglobal
Copy link
Member

  • Select 10 or 20 relevant issue to import manually , and suggest the other to open on new trackers if needed

We could probably automate this if needed to pull all issues and filter out some

  • Or as you say start over in Rust or something else

I'm not that familiar with rust but we might want to look into not just using the rust freerdp2 bindings but something like IronRDP or rdp-rs. We could also take a step away from rdp and look into whatever Rustdesk uses internally

@oskardotglobal
Copy link
Member

Also, this: Fmstrat/winapps#33

@oskardotglobal
Copy link
Member

But lets maybe move this to #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants