-
Notifications
You must be signed in to change notification settings - Fork 320
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: implement fallback for some finders
This implements idea "2" from here: - #393 (comment) > We teach the callers to interpret an empty result list as a cue to > try again using a fallback mechanism; in an empty directory this would > give a false negative but a relatively harmless one (ie. you might run > `:CommandTRipgrep` in an empty folder, and Command-T would take that as > a cue to try again with the standard scanner, which would of course > also return an empty list). Specifically, we do this whenever `git`, `rg`, or `find` returns no results. There is a bit of duplication here because we need thunks at each site; otherwise as soon as we `require`-d the fallback finder it would do a redundant scan. I'm not going to factor that out yet because I am still not convinced that this is an optimal strategy. Want to let it bake for a while and see what happens.
- Loading branch information
Showing
4 changed files
with
38 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters