Unknown symbol "this" when defining an inflight closure inside preflight closure in the entrypoint

[eladb]

I tried this:

See inflight_closure_inside_preflight_closure.test.w:

let foo = () => {
  inflight () => {};
};

BTW, this is working:

class Foo {
  new() {
    let foo = () => {
      inflight () => {};
    };
  }
}

This happened:

error: Unknown symbol "this"

  |
1 | let foo = () => {
  | ^ Unknown symbol "this"

I expected this:

No response

Is there a workaround?

No response

Anything else?

I would propose that our entrypoint scope will include a this symbol, because it's basically the app.

Wing Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

• Please vote by adding a 👍 reaction to the issue to help us prioritize.
• If you are interested to work on this issue, please leave a comment.

[github-actions]

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

[staycoolcall911]

@yoav-steinberg - is this the same as #4925?

[yoav-steinberg]

@yoav-steinberg - is this the same as #4925?

It's almost the same but slightly different. The problem here is that we fail during wing type checking because this doesn't exist in the main scope, but the inflight closure transformer added this. In #4925 this actually exists but behaves differently inside ctors and causes the generated JS to fail in preflight runtime. A fix for #4925 we'll likely fix this too, but it might be worth keeping these separate.