Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all snapshot tests into hangar #715

Closed
MarkMcCulloh opened this issue Nov 23, 2022 · 3 comments
Closed

Consolidate all snapshot tests into hangar #715

MarkMcCulloh opened this issue Nov 23, 2022 · 3 comments
Labels
👷‍♀️ contributor-experience Improvements for contributors' experience good first issue Good for newcomers Stale

Comments

@MarkMcCulloh
Copy link
Contributor

MarkMcCulloh commented Nov 23, 2022 •
edited
Loading

Summary

We currently have snapshot tests in both wingc and hangar. We should just move the JSIR snapshots to hangar so that is the only place needed to update.

Feature Spec

Add additional snapshots to hangar and delete the existing ones in wingc

Use Cases

Reduces contributor friction

Implementation Notes

As part of this, we can additionally move the snapshot files to be next to the examples themselves to aid in discovery/clarity.

Component

Contributor Experience
@MarkMcCulloh MarkMcCulloh added ✨ enhancement New feature or request good first issue Good for newcomers 👷‍♀️ contributor-experience Improvements for contributors' experience and removed ✨ enhancement New feature or request labels Nov 23, 2022
@staycoolcall911 staycoolcall911 moved this to 🆕 New - not properly defined in Wing Nov 24, 2022
@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Nov 24, 2022
@github-actions
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Jan 23, 2023
@staycoolcall911
Copy link
Contributor

keep

@MarkMcCulloh
Copy link
Contributor Author

This was completed in #754

@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👷‍♀️ contributor-experience Improvements for contributors' experience good first issue Good for newcomers Stale
Projects
Wing
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkMcCulloh @staycoolcall911