Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile "ownership tags" into the generated IaC #839

Open
schosterbarak opened this issue Dec 5, 2022 · 5 comments
Open

Compile "ownership tags" into the generated IaC #839

schosterbarak opened this issue Dec 5, 2022 · 5 comments
Labels
☁️ aws Related to Amazon Web Services support ✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl 🎨 sdk SDK 📜 spec Requires a change in the Language/SDK spec

Comments

@schosterbarak
Copy link
Collaborator

schosterbarak commented Dec 5, 2022

Summary

Compile "ownership tags" into the generated IaC

Feature Spec

One of the things I hear a lot from practitioners is the requirement to have "ownership" of cloud resources. Some are using IaC tags, Some runtime tags, and Some innovative ones are using CI logs to trace back the owner.

Ownership is required when you want to know, "who owns the resource that costs so much/ throws errors / has security misconfigs?". Baking tags into the resources helps in those pains.

At bridgecrew we used this util named yor to bake in "ownership" from git log data into IaC.

Maybe it would be interesting to do that in wing compilation-time instead of using tools like yor.

Use Cases

Automatically add tags like:

git_org
git_repo
git_last_modified_by
git_file
git_commit
git_last_modified date

More use cases are detailed here.

Implementation Notes

You can get a lot of data from the git command. It's likely to have it installed for most developers.

Component

Compiler

@schosterbarak schosterbarak added the ✨ enhancement New feature or request label Dec 5, 2022
@monadabot monadabot added this to Wing Dec 5, 2022
@monadabot monadabot moved this to 🆕 New - not properly defined in Wing Dec 5, 2022
@ShaiBer
Copy link
Contributor

ShaiBer commented Dec 5, 2022

Thanks @schosterbarak , I love it!
It will probably take a while to implement though since we first prioritize development of the core functionality of the compiler, and still have much to complete there.

@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Dec 5, 2022
@staycoolcall911 staycoolcall911 added 📜 spec Requires a change in the Language/SDK spec 🎨 sdk SDK labels Dec 5, 2022
@staycoolcall911
Copy link
Contributor

Related to #493

@staycoolcall911
Copy link
Contributor

Seems like this is a good use case for #1218 - FYI @hasanaburayyan, @schosterbarak

@hasanaburayyan
Copy link
Contributor

For sure! We often had the same pain at my last large org, so much so that tagging was enforced via SCP requiring certain tags to exist in order to create certain resoruces.

Inspired from these docs
See: https://docs.aws.amazon.com/organizations/latest/userguide/orgs_manage_policies_scps_examples_tagging.html

But for sure I can see a few ways that #1218 can help with this.

@Chriscbr Chriscbr added the ☁️ aws Related to Amazon Web Services support label Feb 3, 2023
@github-actions
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Apr 20, 2023
@staycoolcall911 staycoolcall911 added the needs-discussion Further discussion is needed prior to impl label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ aws Related to Amazon Web Services support ✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl 🎨 sdk SDK 📜 spec Requires a change in the Language/SDK spec
Projects
Status: 🤝 Backlog - handoff to owners
Development

No branches or pull requests

5 participants