Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #344.
There may be a simpler way to factor the rules but I couldn't find one easily.
The main reason for the complexity is that handling the trailing comma differently (depending on block or simple expression) requires separate rules. This is because alternation cannot be expressed in the rule patterns and the workaround is to use recursion.
Additionally, macros cannot expand in match arm positions, so an accumulator pattern must be used, rather than immediately expanding a match arm and then recursing.
This also has the potential to make the macro expansion for
dispatch
slower (particularly on very large branches, due to the inherent re-parsing of the token trees) but I haven't tested how much of an impact that has.