Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during connection doesn't get propagated up #130

Open
lvjkumar opened this issue Jan 13, 2020 · 2 comments
Open

Error during connection doesn't get propagated up #130

lvjkumar opened this issue Jan 13, 2020 · 2 comments

Comments

@lvjkumar
Copy link

lvjkumar commented Jan 13, 2020

I have a SyslogTransportOptions configured for tcp protocol with a non-existing host but winston-syslog didn't complain about not being able to connect. I expected it to emit error event but it didn't. So when I tried
.on('error',...) on the logger it didn't seem to get fired.

l see there's a TODO marked in winston-syslog.js:
winston-syslog.js v2.4.0:

.on('error', function () {
        //
        // TODO: Pass this error back up
        //
      })

Is this expected to be fixed any soon?

@lvjkumar lvjkumar changed the title Errors during connection doesn't get propagated up Error during connection doesn't get propagated up Jan 15, 2020
@NightWatchman
Copy link

I'm trying to use winston-syslog and I get no errors, but no logs either. Logging to other transports works fine. I can't find anything wrong with my configuration.

Now I wonder if this is why it's silently failing.

@wbt
Copy link
Contributor

wbt commented May 4, 2022

PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants