Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: separate Console transport into proper Console, and separate StdOut #1836

Open
baybal opened this issue Aug 13, 2020 · 0 comments
Open

Comments

@baybal
Copy link

baybal commented Aug 13, 2020

Following #1787 #1774 #1636 #1609, and ultimately #1544. I think we need to put it clearly that console, and stdout are two different things.

What's the feature?

I propose to split the Console transport into one that uses actual console, and one specifically stdout/stderr.

The global console object may often be overridden, or have its methods wrapped/redefined by other debug tooling.

I believe users explicitly choosing console output are ones who need this for debug/tooling purposes, and that functionality should not be impacted by winston.

I prepared a PR #1835 that restored console transport usage of console.log without impacting wrappers/debugging, and avoiding the threat of circular invocation at the same time.

The PR edits work fine for me. You can edit your CI tests to omit EOL checks for Console transport, and create the StdOut transport from the old version of Console transport.

What problem is the feature intended to solve?

Allow users needing real console.log output able to use it, while leaving stdout output as is.

Is the absence of this feature blocking you or your team? If so, how?

I can't see inspector/debugger output. It prevents logging showing up in microservice frameworks that have their own console.log implementations.

Is this feature similar to an existing feature in another tool?

No

Is this a feature you're prepared to implement, with support from us?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant