You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned in v3.0 upgrade notes, the callback support was removed since "the vast majority of use cases for this feature was folks awaiting all logging to complete". We have a problem with this approach as stated in 502 since googleapis/nodejs-logging-winston uses async APIs to send logging records to the cloud which is preferable way to send logs in order to avoid cloud services delays/disruptions and which used callbacks as an approach to track logging completion.
I believe that there should be a level of backward compatibility maintained for such functionality so the users can adopt a change or even have an option to choose desired functionality based on user's services architecture (correct me if I wrong, but callback is still a valid node paradigm).
What version of Winston presents the issue?
v3.0.0
What version of Node are you using?
v14.17.6
If this worked in a previous version of Winston, which was it?
v2.x
Minimum Working Example
No response
Additional information
No response
The text was updated successfully, but these errors were encountered:
My understanding is that promises are preferred over callbacks these days.
However, it does seem like it'd be potentially useful to have promisified versions of the logging functions that return [ignorable] promises resolving when the logging action has completed.
🔎 Search Terms
callback
The problem
As mentioned in v3.0 upgrade notes, the callback support was removed since "the vast majority of use cases for this feature was folks awaiting all logging to complete". We have a problem with this approach as stated in 502 since
googleapis/nodejs-logging-winston
usesasync
APIs to send logging records to the cloud which is preferable way to send logs in order to avoid cloud services delays/disruptions and which used callbacks as an approach to track logging completion.I believe that there should be a level of backward compatibility maintained for such functionality so the users can adopt a change or even have an option to choose desired functionality based on user's services architecture (correct me if I wrong, but callback is still a valid node paradigm).
What version of Winston presents the issue?
v3.0.0
What version of Node are you using?
v14.17.6
If this worked in a previous version of Winston, which was it?
v2.x
Minimum Working Example
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: