crop method not called in ImageResizer

[mjauvin]

Winter CMS Build

dev-develop

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

When using the ImageResizer with mode:crop, the crop() method never gets called.

Steps to replicate

Twig markup:

<img src="{{ 'image-path' | theme | resize(200, 100, {mode: 'crop'}) }}">

Plugin boot method:

Event::listen('system.resizer.processCrop', function ($resizer, $localTempPath) {
    trace_log("this won't show up");
});

Workaround

No response

[bennothommo]

@mjauvin I'm not sure that using mode: crop is synonymous with using the crop command in the ImageResizer class - it appears that crop is just a shortcut method. Further, it appears that the resize filter is passing everything through the resize method anyway, which just filters down to the Winter\Storm\Database\Attach\Resize utility class which does the actual resizing/cropping.

My guess is that the crop method was being set up to be used for a separate crop filter in Twig.

[LukeTowers]

@mjauvin could you provide an example of what you were wanting to use the event for?

[mjauvin]

@LukeTowers I created a betterCrop() method that can crop from the different sides & corners of an image and I wanted to use the event for this.

[LukeTowers]

@mjauvin so right now you're just using the resize event instead?

[mjauvin]

@mjauvin so right now you're just using the resize event instead?

Correct

[bennothommo]

Let's close this off for now unless someone is able to confirm that using { mode: crop} doesn't actually crop the image (regardless of it being passed through to the resize() method.