refactor: simplify type definitions, clean up unused code, and improve encapsulation (#19610)

- Refactored component interfaces to remove unnecessary exports and limit scope (e.g., AvatarProps, ChannelAvatarProps, etc.)
- Updated some interfaces to remove redundant HTML prop inheritance
- Added missing props to AvatarWrapperProps for better flexibility and type safety
- Removed unused imports, constants, and functions (e.g., localeConfig.ts, errorUtil.tsx)
- Deleted unused index.ts in AppContainer component
- Adjusted constant scopes to reduce visibility (e.g., timer constants in EnrollmentTimer.ts)
- Streamlined imports and applied minor code style improvements

Author: e-maad

src/script/E2EIdentity/EnrollmentTimer/EnrollmentTimer.ts

@@ -23,12 +23,11 @@ import {CredentialType} from '@wireapp/core/lib/messagingProtocols/mls';
 
 import {MLSStatuses, WireIdentity} from '../E2EIdentityVerification';
 
-export const ONE_MINUTE = TimeInMillis.MINUTE;
-export const FIVE_MINUTES = TimeInMillis.MINUTE * 5;
-export const FIFTEEN_MINUTES = TimeInMillis.MINUTE * 15;
-export const ONE_HOUR = TimeInMillis.HOUR;
-export const FOUR_HOURS = TimeInMillis.HOUR * 4;
-export const ONE_DAY = TimeInMillis.DAY;
+const FIVE_MINUTES = TimeInMillis.MINUTE * 5;
+const FIFTEEN_MINUTES = TimeInMillis.MINUTE * 15;
+const ONE_HOUR = TimeInMillis.HOUR;
+const FOUR_HOURS = TimeInMillis.HOUR * 4;
+const ONE_DAY = TimeInMillis.DAY;
 
 // message retention time on backend (hardcoded to 28 days)
 export const messageRetentionTime = 28 * TimeInMillis.DAY;

src/script/auth/component/AcceptNewsModal.tsx

@@ -27,7 +27,7 @@ import {t} from 'Util/LocalizerUtil';
 
 import {Config} from '../../Config';
 
-export interface Props extends React.HTMLProps<HTMLDivElement> {
+interface Props {
   onConfirm: (event: React.MouseEvent<HTMLButtonElement>) => void;
   onDecline: (event: React.MouseEvent<HTMLButtonElement>) => void;
 }

src/script/auth/component/AccountAlreadyExistsModal.tsx

@@ -24,7 +24,7 @@ import {t} from 'Util/LocalizerUtil';
 
 import {buttonCss, containerCss, headerCss, linkCss} from './AccountAlreadyExistsModal.styles';
 
-export interface AccountAlreadyExistsModalProps {
+interface AccountAlreadyExistsModalProps {
   onClose: () => void;
 }
 

src/script/auth/component/ClientItem.tsx

@@ -43,7 +43,7 @@ import {splitFingerprint} from 'Util/StringUtil';
 import {ValidationError} from '../module/action/ValidationError';
 import {parseError, parseValidationErrors} from '../util/errorUtil';
 
-export interface Props extends HTMLProps<HTMLDivElement> {
+interface Props extends HTMLProps<HTMLDivElement> {
   client: RegisteredClient;
   onClick: (event: MouseEvent<HTMLDivElement> | KeyboardEvent) => void;
   onClientRemoval: (password?: string) => void;

src/script/auth/component/JoinGuestLinkPasswordModal.tsx

@@ -17,7 +17,7 @@
  *
  */
 
-import React, {useState} from 'react';
+import {FormEvent, useState} from 'react';
 
 import {StatusCodes as HTTP_STATUS} from 'http-status-codes';
 
@@ -35,16 +35,16 @@ export interface JoinGuestLinkPasswordModalProps {
   onClose: () => void;
 }
 
-const JoinGuestLinkPasswordModal: React.FC<JoinGuestLinkPasswordModalProps> = ({
+const JoinGuestLinkPasswordModal = ({
   error,
   onClose,
   isLoading,
   conversationName,
   onSubmitPassword,
-}) => {
+}: JoinGuestLinkPasswordModalProps) => {
   const [passwordValue, setPasswordValue] = useState<string>('');
 
-  const onSubmit = (event: React.FormEvent<HTMLFormElement | HTMLButtonElement>) => {
+  const onSubmit = (event: FormEvent<HTMLFormElement | HTMLButtonElement>) => {
     event.preventDefault();
     onSubmitPassword(passwordValue);
   };
@@ -70,7 +70,7 @@ const JoinGuestLinkPasswordModal: React.FC<JoinGuestLinkPasswordModalProps> = ({
         <Form
           name="guest-password-join-form"
           data-uie-name="guest-password-join-form"
-          onSubmit={(event: React.FormEvent<HTMLFormElement>) => onSubmit(event)}
+          onSubmit={(event: FormEvent<HTMLFormElement>) => onSubmit(event)}
           autoComplete="off"
         >
           <Input
@@ -98,7 +98,7 @@ const JoinGuestLinkPasswordModal: React.FC<JoinGuestLinkPasswordModalProps> = ({
           block
           type="button"
           disabled={!passwordValue}
-          onClick={(event: React.FormEvent<HTMLButtonElement>) => onSubmit(event)}
+          onClick={(event: FormEvent<HTMLButtonElement>) => onSubmit(event)}
           data-uie-name="guest-link-join-submit-button"
         >
           {t('guestLinkPasswordModal.joinConversation')}

src/script/auth/component/ProgressBar.tsx

@@ -17,14 +17,15 @@
  *
  */
 
-import * as React from 'react';
+import type {CSSProperties} from 'react';
 
 interface ProgressProps {
-  error: boolean;
-  percent: number;
-  style?: React.CSSProperties;
   width: number;
+  percent: number;
+  error?: boolean;
+  style?: CSSProperties;
 }
+
 export const ProgressBar = ({width, percent, error, style}: ProgressProps) => {
   const progress = (percent / 100) * width;
 

src/script/auth/component/WirelessContainer.tsx

@@ -29,13 +29,13 @@ import {t} from 'Util/LocalizerUtil';
 import {Config} from '../../Config';
 import {EXTERNAL_ROUTE} from '../externalRoute';
 
-export interface Props extends React.HTMLAttributes<HTMLDivElement> {
+interface WirelessContainerProps {
   children: React.ReactNode;
   onCookiePolicyBannerClose?: (event: React.MouseEvent<HTMLElement>) => void;
   showCookiePolicyBanner?: boolean;
 }
 
-const WirelessContainer: React.FC<Props> = ({showCookiePolicyBanner, onCookiePolicyBannerClose, children}) => {
+const WirelessContainer = ({showCookiePolicyBanner, onCookiePolicyBannerClose, children}: WirelessContainerProps) => {
   return (
     <div
       style={{

src/script/auth/localeConfig.ts

@@ -17,14 +17,11 @@
  *
  */
 
-import {SupportedCurrency} from '@wireapp/api-client/lib/team/payment/';
-
 import {UrlUtil} from '@wireapp/commons';
 
 import {QUERY_KEY} from './route';
 import {supportedLocales as Locales} from './supportedLocales';
 
-const DEFAULT_CURRENCY = SupportedCurrency.EUR;
 const DEFAULT_LANGUAGE = 'en-US';
 
 function getLocale(): string {
@@ -35,10 +32,6 @@ export function currentLanguage(): string {
   return mapLanguage(UrlUtil.getURLParameter(QUERY_KEY.LANGUAGE) || getLocale());
 }
 
-export function currentCurrency(): SupportedCurrency {
-  return (UrlUtil.getURLParameter(QUERY_KEY.CURRENCY).toUpperCase() as SupportedCurrency) || DEFAULT_CURRENCY;
-}
-
 export function normalizeLanguage(language: string = DEFAULT_LANGUAGE): string {
   const LANGUAGE_SHORTHAND_LENGTH = 2;
   return language.substring(0, LANGUAGE_SHORTHAND_LENGTH);

src/script/auth/page/ConversationJoin.tsx

@@ -17,7 +17,7 @@
  *
  */
 
-import React, {useEffect, useState} from 'react';
+import {useEffect, useState, useRef, FormEvent} from 'react';
 
 import type {RegisterData} from '@wireapp/api-client/lib/auth';
 import {BackendErrorLabel} from '@wireapp/api-client/lib/http';
@@ -72,7 +72,7 @@ const ConversationJoinComponent = ({
   generalError,
   doGetAllClients,
 }: Props & ConnectedProps & DispatchProps) => {
-  const nameInput = React.useRef<HTMLInputElement>(null);
+  const nameInput = useRef<HTMLInputElement>(null);
 
   const conversationHasPassword = conversationInfo?.has_password;
 
@@ -205,7 +205,7 @@ const ConversationJoinComponent = ({
     }
   };
 
-  const checkNameValidity = async (event: React.FormEvent) => {
+  const checkNameValidity = async (event: FormEvent) => {
     setIsTemporaryGuest(true);
     event.preventDefault();
     if (!nameInput.current) {

src/script/auth/page/SingleSignOnForm.tsx

@@ -48,7 +48,7 @@ import {getEnterpriseLoginV2FF} from '../util/helpers';
 import {logoutReasonStrings} from '../util/logoutUtil';
 import {getSearchParams, SSO_CODE_PREFIX} from '../util/urlUtil';
 
-export interface SingleSignOnFormProps extends React.HTMLAttributes<HTMLDivElement> {
+interface SingleSignOnFormProps {
   doLogin: (code: string) => Promise<void>;
   initialCode?: string;
 }