Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global infinite retries cause a lot of problems #17680

Open
1 of 4 tasks
barryoo opened this issue Jul 3, 2024 · 0 comments
Open
1 of 4 tasks

Global infinite retries cause a lot of problems #17680

barryoo opened this issue Jul 3, 2024 · 0 comments

Comments

@barryoo
Copy link

barryoo commented Jul 3, 2024

Your Account Type

What steps will reproduce the problem?

Clicking on a contact in the Contacts bar, I want to open a new conversation, but due to network problems, the request fails, and then I click multiple times, which results in multiple retry requests. When the network is restored, multiple conversation appear.

What is the expected behaviour?

Click on a contact multiple times, even if a network problem causes the request to result in, when the network is restored, only one conversation will appear


In api-client, axios-retry is used, so all requests are retried infinite. In fact, it's not just the problem I reported above, but also in other behaviors. This is caused by infinite retries. This issue does not occur in Android/IOS versions.
I don't think global infinite retries are a good design, they should be done only when they are really needed, like sending a message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant