Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]Add ability to embed the images into the HTML output #199

Closed
martonmiklos opened this issue Nov 19, 2020 · 2 comments
Closed

[feature]Add ability to embed the images into the HTML output #199

martonmiklos opened this issue Nov 19, 2020 · 2 comments

Comments

@martonmiklos
Copy link
Contributor

I think it would be useful to add an option to being able to embed images to HTML output in base64 encoded format. This would make the HTML output more "portable" or sharing friendly. i.e. one could share the plan as a single HTML file an call it a day.

Syntax wise I would just add an 'embed' boolean under the image tags.

If no objections arose about this I could came up with a PR.

@formatc1702
Copy link
Collaborator

formatc1702 commented Nov 19, 2020

  • master already implements embedding the SVG diagram within the HTML output.
  • Embed images in SVG output #189 will add the functionality of taking any images referenced in the YAML and embedding them into the SVG file. This, in turn, also carries over to the HTML output.

So either way, you already get one "portable" HTML file as output.

Or are you suggesting something else? If so, maybe you could elaborate, or present an example mockup of what you imagine.

@martonmiklos
Copy link
Contributor Author

#189 will add the functionality of taking any images referenced in the YAML and embedding them into the SVG file. This, in turn, also carries over to the HTML output.

Ah I was not aware of this change or more exactly I thought that the images were part of the HTML output not the SVG. But I am glad to see that you found workarounds for the graphviz limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants