Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Inconsistent horizontal alignment #90

Closed
kvid opened this issue Jul 15, 2020 · 2 comments
Closed

[bug] Inconsistent horizontal alignment #90

kvid opened this issue Jul 15, 2020 · 2 comments

Comments

@kvid
Copy link
Collaborator

kvid commented Jul 15, 2020

Single-line connector attributes are centered horizontally in the diagram when smaller than the available space, but the graphviz_line_breaks() function makes multi-line attributes left aligned:
https://github.com/formatc1702/WireViz/blob/34cd9c26126231eeb25f93af245b0a24e8d45ed8/src/wireviz/wv_helper.py#L120

In the wire nodes (formatted with HTML), both single- and multi-line attributes are centered.

@kvid
Copy link
Collaborator Author

kvid commented Jul 15, 2020

Some users might argue that they prefer left-aligned multi-line attributes. IMHO, that would be a new optional feature request.

@formatc1702
Copy link
Collaborator

formatc1702 commented Jul 15, 2020

I intentionally used \l because I thought it would look better (thus the comment, since \l is quite unusual), but you are right, centered looks more consistent. I'll think about adding alignment options later, but it's not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants