astro:db: isDbError functions differently with remote and local DB

[timsexperiments]

Astro Info

Astro                    v4.6.2
Node                     v21.7.3
System                   macOS (arm64)
Package Manager          bun
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/tailwind
                         astro:db
                         @astrojs/db/file-url

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When running astro with the astro db plugin, the isDbError function is only working when running locally or using a file in the output. However, when running with a remote db the error is getting transformed to an AstroDbError.

{
    "type": "AstroUserError",
    "hint": "See the Astro DB guide for query and push instructions: https://docs.astro.build/en/guides/astro-db/#query-your-database",
    "name": "Astro DB Error",
    "message": "UNIQUE constraint failed: Item.value"
}

This causes the isDbError function to return false:

export function isDbError(err: unknown): err is LibsqlError {
	return err instanceof LibsqlError;
}

Having different expectations for local and remote databases means that code is not testable locally without actually connecting to a remote astro db. This means I need to write different code for local development and my production build.

What's the expected result?

I would expect one of the following:

• Remote and local runs using the import { db } from 'astro:db' to return the same error no matter what environment (locally, file based, remote).
• AstroDbError to also return true when running isDbError. However the err is LibsqlError will be false. I would expect a single function that should work for both file based libsql queries and for astro remote db queries.

Link to Minimal Reproducible Example

https://stackblitz.com/~/github.com/timsexperiments/astro-db-test

Participation

• I am willing to submit a pull request for this issue.

[ematipico]

cc @bholmesdev

[bholmesdev]

Ah thanks for noticing @timsexperiments! The error signature was changed recently, and we missed a test for isDbError() against the remote database. Local and remote should return the same error object. Need to decide whether local should return an AstroError instead, with access to the base LibsqlError