Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrojs/upgrade still using "preferred-pm": "^4.0.0" #13102

Closed
1 task
Smart-Ace-Designs opened this issue Jan 30, 2025 · 3 comments · Fixed by #13074
Closed
1 task

@astrojs/upgrade still using "preferred-pm": "^4.0.0" #13102

Smart-Ace-Designs opened this issue Jan 30, 2025 · 3 comments · Fixed by #13074
Labels
- P1: chore Doesn't change code behavior (priority)

Comments

@Smart-Ace-Designs
Copy link

Astro Info

Astro                    v5.2.1
Node                     v22.13.1
System                   Windows (x64)
Package Manager          unknown
Output                   static
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

"preferred-pm" 4.1.0 is required to support new "bun.lock" file (text based). However, it looks like @astrojs/upgrade is still using 4.0.0. Could this be updated to 4.1.0 to allow for bun 1.2 to work correctly (when using new bun.lock file) with @astrojs/upgrade? Currently, it reverts back to npm since 4.0.0 only looks for the bun.lockb file.

Image

See #13065 for more info.

Thank you.

What's the expected result?

@astrojs/upgrade package.json file should use "preferred-pm": "^4.1.0"

Since this is a CLI issue, there is no StackBlitz reproduction.

Link to Minimal Reproducible Example

http://localhost:4321

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jan 30, 2025
@florian-lefebvre florian-lefebvre linked a pull request Jan 31, 2025 that will close this issue
1 task
@ematipico
Copy link
Member

Feel free to send a PR

@ematipico ematipico reopened this Jan 31, 2025
@florian-lefebvre florian-lefebvre added - P1: chore Doesn't change code behavior (priority) and removed needs triage Issue needs to be triaged labels Jan 31, 2025
@Smart-Ace-Designs
Copy link
Author

Thank you.

@Smart-Ace-Designs
Copy link
Author

What needs to happen to get this new version published to npm so that is it usable...or will this eventually happen on it own through some sort of automated process?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P1: chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants