You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small suggestion: I’ve noticed that we all have different styles when it comes to expanding different methods for node:path. I’ve even seen us have local variables named path that cause us to remap node:path to something else entirely to avoid conflict. It’s just different in every file. Here, I think renaming posix as path may be a little unexpected here, especially if non-POSIX is needed.
What do you think about just standardizing import path from 'path' in the project everywhere? It’s a little more verbose but it’s predictable, and we don’t need to keep changing import statements every time we need a new method
Related: should we just use import fs from 'fs'; as well, too? I don’t feel as strongly about fs but it follows a similar pattern of every module renames common methods differently
Small suggestion: I’ve noticed that we all have different styles when it comes to expanding different methods for
node:path
. I’ve even seen us have local variables namedpath
that cause us to remapnode:path
to something else entirely to avoid conflict. It’s just different in every file. Here, I think renamingposix as path
may be a little unexpected here, especially if non-POSIX is needed.What do you think about just standardizing
import path from 'path'
in the project everywhere? It’s a little more verbose but it’s predictable, and we don’t need to keep changing import statements every time we need a new methodOriginally posted by @drwpow in #231 (comment)
The text was updated successfully, but these errors were encountered: