Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base config is ignored on build #4468

Closed
1 task done
kagankan opened this issue Aug 25, 2022 · 1 comment · Fixed by #4469
Closed
1 task done

base config is ignored on build #4468

kagankan opened this issue Aug 25, 2022 · 1 comment · Fixed by #4469

Comments

@kagankan
Copy link
Contributor

What version of astro are you using?

1.0.7

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Windows 10

Describe the Bug

after astro build with base config, fail loading image from script.
image path in the script should be /(base)/assets/images/image.png but it's /assets/images/image.png.
base config is ignored.

in this PR, base: astroConfig.base, was deleted, but this is NOT from viteConfig, so this line is needed
https://github.com/withastro/astro/pull/4344/files

Link to Minimal Reproducible Example

https://github.com/kagankan/astro-sample/tree/sample/base-config-bug

Participation

  • I am willing to submit a pull request for this issue.
@matthewp
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants