Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev server needs to be restarted for tsconfig.json changes to be picked up #4914

Closed
1 task
Princesseuh opened this issue Sep 29, 2022 · 2 comments · Fixed by #4947
Closed
1 task

Dev server needs to be restarted for tsconfig.json changes to be picked up #4914

Princesseuh opened this issue Sep 29, 2022 · 2 comments · Fixed by #4947
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@Princesseuh
Copy link
Member

Princesseuh commented Sep 29, 2022 •
edited
Loading

What version of astro are you using?

1.3.2

Are you using an SSR adapter? If so, which one?

N/A

What package manager are you using?

pnpm

What operating system are you using?

macOS

Describe the Bug

Changes to tsconfig.json are not picked up until the dev server is restarted, in most cases this doesn't matter, but it's annoying when working with aliases since every change requires a restart

When implementing this, make sure that changes to files the tsconfig.json extends from are also picked up!

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-ywqjca?file=tsconfig.json&on=stackblitz

Participation

  • I am willing to submit a pull request for this issue.
@Princesseuh Princesseuh added the - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Sep 29, 2022
@rishi-raj-jain
Copy link
Contributor

I wonder if this is supported by any framework out there right now?

@Princesseuh
Copy link
Member Author

I wonder if this is supported by any framework out there right now?

Yep, vanilla Vite actually support this, it's an Astro specific issue

@JuanM04 JuanM04 mentioned this issue Oct 1, 2022
Merged
@matthewp matthewp added - P4: important Violate documented behavior or significantly impacts performance (priority) and removed - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) labels Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: restart dev server when tsconfig and tailwind config changes withastro/astro
3 participants
@matthewp @Princesseuh @rishi-raj-jain