Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue library "primevue" needs configuration #5563

Closed
1 task
louiss0 opened this issue Dec 8, 2022 · 4 comments · Fixed by #5571
Closed
1 task

Vue library "primevue" needs configuration #5563

louiss0 opened this issue Dec 8, 2022 · 4 comments · Fixed by #5571
Assignees
Labels
- P2: nice to have Not breaking anything but nice to have (priority)

Comments

@louiss0
Copy link
Contributor

louiss0 commented Dec 8, 2022

What version of astro are you using?

1.6.1

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

pnpm

What operating system are you using?

Windows

Describe the Bug

I tried using prime vue in my vue app but i ran into a problem that I had to solve with this setting

ssr: {
      noExternal: ["primevue"],
  },

Why did I have to deal with this problem if you take this setting off then the prime Vue file will be bundled into the server entry. which is what I don't want apparently. I hope I don't have to deal with this again. I don't like configuring at all.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-nqn7zc?file=src%2Fbootstrap.ts,astro.config.mjs,dist%2Fentry.mjs&on=stackblitz

Participation

  • I am willing to submit a pull request for this issue.
@matthewp matthewp changed the title Found a problem with the server Vue library "primevue" needs configuration Dec 9, 2022
@matthewp
Copy link
Contributor

matthewp commented Dec 9, 2022

@louiss0 Not all libraries work without configuration, that's why the configuration exists in the first place. Please be kinder in your bug reports.

It looks like this is a popular library so I'll make it so that we have this setting as part of the Vue integration.

@matthewp matthewp added the - P2: nice to have Not breaking anything but nice to have (priority) label Dec 9, 2022
@matthewp matthewp self-assigned this Dec 9, 2022
@fprl
Copy link
Contributor

fprl commented Dec 13, 2022

FYI, this makes configuration neccesary in SSR (at least on Vercel). Now we need to specify the opposite:

ssr: {
      external: ["primevue"],
  },

@matthewp
Copy link
Contributor

@francoromanol Oh, that's really unfortunate. Do you have any idea why you need to make it be external?

@carlos00027
Copy link

I don't understand how I can add primevue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P2: nice to have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants