Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[astro-rss] Stylesheets no longer work in 1.1.0 #5581

Closed
1 task
fflaten opened this issue Dec 11, 2022 · 7 comments · Fixed by #5600
Closed
1 task

[astro-rss] Stylesheets no longer work in 1.1.0 #5581

fflaten opened this issue Dec 11, 2022 · 7 comments · Fixed by #5600

Comments

@fflaten
Copy link
Contributor

fflaten commented Dec 11, 2022

What version of astro are you using?

1.6.14

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Linux

Describe the Bug

RSS Stylesheets are not rendered in astro-rss v1.1.0 due to missing type="text/xsl"-attribute removed in #5550.

# 1.0.* working
<?xml-stylesheet href="/pretty-feed-v3.xsl" type="text/xsl"?>

# 1.1.0 broken
<?xml-stylesheet href="/pretty-feed-v3.xsl" encoding="UTF-8"?>

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-dsatf5

Participation

  • I am willing to submit a pull request for this issue.
@fflaten
Copy link
Contributor Author

fflaten commented Dec 11, 2022

In repro, visit /rss.xml in the preview. Downgrade @astrojs/rss to 1.0.0 to see working stylesheet

@matthewp
Copy link
Contributor

@fflaten can you submit a PR to fix this?

@fflaten
Copy link
Contributor Author

fflaten commented Dec 12, 2022

Unfortunately not this time.

Build fails in the included devcontainer and I don't currently have time to troubleshoot. Not sure if it's user error or a new issue, but getting this:
image

@le0pard
Copy link

le0pard commented Dec 13, 2022

Had same issue. Downgrade helps. In previous version generated:

<?xml-stylesheet href="/rss/styles.xsl" type="text/xsl"?>

In version 1.1.0 generated (no attribute "type" and not needed attribute "encoding"):

<?xml-stylesheet href="/rss/styles.xsl" encoding="UTF-8"?>

Also 1.1.0 break usage of CDATA in title/description tags and encode everything inside it. No option back CDATA usage.

@matthewp
Copy link
Contributor

@le0pard sorry about this, if you're familiar with these features would you mind seeing a PR to fix?

@fflaten
Copy link
Contributor Author

fflaten commented Dec 13, 2022

Unfortunately not this time.

Build fails in the included devcontainer and I don't currently have time to troubleshoot. Not sure if it's user error or a new issue, but getting this: image

Might have been a resource-issue using github codespace. Worked fine in devcontainer locally, so will submit a PR as soon as I get familiar with chai.

Also 1.1.0 break usage of CDATA in title/description tags and encode everything inside it. No option back CDATA usage.

@le0pard Do you mind posting this a new issue so it's not forgotten? 🙂

@le0pard
Copy link

le0pard commented Dec 27, 2022

Thanks, issue created - #5677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants