Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lit nested components results in error #6743

Closed
1 task
RogierdeRuijter opened this issue Apr 3, 2023 · 1 comment · Fixed by #6752
Closed
1 task

Lit nested components results in error #6743

RogierdeRuijter opened this issue Apr 3, 2023 · 1 comment · Fixed by #6752

Comments

@RogierdeRuijter
Copy link

What version of astro are you using?

2.1.8

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

When rendering 2 lit components inside of each other an error is thrown: elementRenderers is not iterable.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/node-x8wcke?file=index.js

Participation

  • I am willing to submit a pull request for this issue.
@augustjk
Copy link
Contributor

augustjk commented Apr 4, 2023

I think the issue is this line

const shadowContents = instance.renderShadow({});

Providing an empty object for the render info option there so it's not able to handle nested custom elements without any element renderers to handle. I can work on a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants