Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrojs/sitemap filter doesn't apply to endpoints #7081

Closed
1 task
fflaten opened this issue May 12, 2023 · 4 comments
Closed
1 task

@astrojs/sitemap filter doesn't apply to endpoints #7081

fflaten opened this issue May 12, 2023 · 4 comments

Comments

@fflaten
Copy link
Contributor

fflaten commented May 12, 2023

What version of astro are you using?

2.4.5

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Linux

What browser are you using?

Edge

Describe the Bug

Using astrojs/sitemap 1.3.0+ endpoints likes images, rss etc are included in sitemap (#7080). The same URLs are not processed by the filter-feature leaving no option but to stick with 1.2.2 release to avoid sitemap-entries causing 404.

Repro: Run build in sample and compare URLs printed in console with sitemap-0.xml.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-xfdxg4?file=astro.config.mjs

Participation

  • I am willing to submit a pull request for this issue.
@neulandherzer-dev
Copy link

I find that the filter feature does not work at all in that version. All pages are always included in the sitemap.

@kevintanu
Copy link

it's still broken on 1.3.1, stick to 1.2.2 instead

@SenseiMarv
Copy link

It also adds the injected _image route from the @astrojs/image integration, which results in a 404 page.
And it adds the RSS route from the @astrojs/rss integration with a trailing slash, which is a problem for me because I use the @astrojs/vercel adapter with "cleanUrls": true to address this issue and need to have the route end without trailing slash.

Since the filter no longer works, I can't remove these pages and routes with @astrojs/sitemap 1.3.0+.

@bluwy
Copy link
Member

bluwy commented Jun 2, 2023

This should be fixed in #7263

@bluwy bluwy closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants