Astro info throws when xclip is not available

[fflaten]

Astro Info

> @fflaten/website@0.0.1 astro /workspaces/Website
> astro "info"

Astro                    v3.5.0
Node                     v18.16.0
System                   Linux (x64)
Package Manager          pnpm
Output                   static
Adapter                  none
Integrations             config-watcher
                         auto-import
                         @astrojs/sitemap
                         @astrojs/asides
                         astro-expressive-code
                         @astrojs/mdx
 error   Command failed: which xclip
  File:
    /workspaces/Website/node_modules/.pnpm/astro@3.5.0_@types+node@20.9.0_sass@1.69.5/node_modules/astro/dist/cli/info/index.js:38:20
  Code:
    37 |   } else {
    > 38 |     const output = execSync("which xclip", { encoding: "utf8" });
         |                    ^
      39 |     if (output[0] !== "/") {
      40 |       return;
      41 |     }
  Stacktrace:
Error: Command failed: which xclip
    at checkExecSyncError (node:child_process:885:11)
    at execSync (node:child_process:957:15)
    at copyToClipboard (file:///workspaces/Website/node_modules/.pnpm/astro@3.5.0_@types+node@20.9.0_sass@1.69.5/node_modules/astro/dist/cli/info/index.js:38:20)
    at printInfo (file:///workspaces/Website/node_modules/.pnpm/astro@3.5.0_@types+node@20.9.0_sass@1.69.5/node_modules/astro/dist/cli/info/index.js:28:9)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runCommand (file:///workspaces/Website/node_modules/.pnpm/astro@3.5.0_@types+node@20.9.0_sass@1.69.5/node_modules/astro/dist/cli/index.js:69:7)
    at async cli (file:///workspaces/Website/node_modules/.pnpm/astro@3.5.0_@types+node@20.9.0_sass@1.69.5/node_modules/astro/dist/cli/index.js:144:5)

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Error is thrown by execSync on non-zero exit code (xclip was not found). Missing try/catch here:

astro/packages/astro/src/cli/info/index.ts

Lines 53 to 57 in a888e98

	const output = execSync('which xclip', { encoding: 'utf8' });
	if (output[0] !== '/') {
	// Did not find a path for xclip, bail out!
	return;
	}

What's the expected result?

No error

Link to Minimal Reproducible Example

N/A

Participation

• I am willing to submit a pull request for this issue.

[matthewp]

Good catch! Do you want to submit a PR that wraps that in a try/catch and bails out in the catch? Would be much appreciated.

[fflaten]

Thanks for the quick triage.
I might this weekend, but consider it up for grabs. I already have a backlog to tackle 🙂