custom status code does not seem to be respected in configured redirects

[JulioGrajales]

Astro Info

Astro                    v4.0.8
Node                     v21.5.0
System                   Windows (x64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/tailwind
                         @astrojs/svelte

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Configured redirects don't seem to respect a custom status code when provided using an object. using the following configuration:

redirects: {
    '/hello': {
      status: 302,
      destination: '/other',
    },
  },

does not use 302 status code and instead uses 301 status code (the default). I'm in SSR mode, using node adapter.

What's the expected result?

It should redirect me using 302 status code or any other valid custom status code provided in the configured redirect object.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-9cfd3y?file=astro.config.mjs

Participation

• I am willing to submit a pull request for this issue.

[florian-lefebvre]

An interesting thing to check would be to see if it's node specific or if it also happens with other adapters like vercel

[ematipico]

An interesting thing to check would be to see if it's node specific or if it also happens with other adapters like vercel

I can replicate it in dev using the stackblitz example, so it's probably an issue in core

[Runeloon]

Appears this fix doesn't work in the latest 4.2.4 release. Bit difficult to work out why, as the create.ts appears to have gone through a bit of a rework.
Have verified at least that upon hitting redirectRouteStatus, the redirectRoute.redirectRoute property is null, meaning it never bothers checking the redirectRoute.redirect.status, which is set.
Testing example of input to redirectRouteStatus in 4.2.4:
{ type: 'redirect', isIndex: false, route: '/test1', pattern: /^\/test1\/?$/, segments: [ [ [Object] ] ], params: [], component: '/test1', generate: [Function (anonymous)], pathname: '/test1', prerender: false, redirect: { status: 302, destination: '/test2' }, redirectRoute: undefined, fallbackRoutes: [] }

[ematipico]

@Runeloon can you provide a reproduction?

[lilnasy]

The reproduction provided here behaves as expected now. If there's still a case where it doesn't work, it would be a distinct issue.

[JulioGrajales]

I did some tests myself and discovered a strange behavior.

Astro info:

Astro                    v4.2.5
Node                     v21.6.1
System                   Windows (x64)
Package Manager          pnpm
Output                   server
Adapter                  @astrojs/node
Integrations             none

there is apparently a difference in behavior depending on whether you add a trailing slash ( / ) to the destination property of the configured redirect object or not.

no trailing slash:

astro.config.mjs:

import { defineConfig } from 'astro/config';

// https://astro.build/config
export default defineConfig({
  redirects: {
    '/hello': {
      status: 302,
      destination: '/other',
    },
  },
});

trailing slash:

astro.config.mjs:

import { defineConfig } from 'astro/config';

// https://astro.build/config
export default defineConfig({
  redirects: {
    '/hello': {
      status: 302,
      destination: '/other/',
    },
  },
});

Reproduction:
https://stackblitz.com/edit/github-paatym?file=astro.config.mjs