-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch is not allowed to deploy to github-pages #1376
Comments
Probably related to #1355. @odwrotnie Can you try switching your Settings > Pages > Source to "GitHub Actions" and see if that works? |
What's baffling to me is that there's nearly a hundred repositories using the withastro/action@v0 workflow action, and they seem to work just fine. Did nobody have issues with this until now? Did something recently change that makes the GitHub deployment guide outdated? |
Sorry for the inconvenience, we switched actions lately from |
Switching didn't help :(. |
@odwrotnie Interesting, can you look into Settings > Environments and report what you see? You should see a github-pages environment: And inside of it a deployment branch rule that's just the name of your deployment branch. In your case "main". Alternatively, you should just be able to switch from "Selected branches" to "All branches" to remove all branch restricitons. |
I'm not sure why this breaks occasionally. It's supposed to automatically set itself up when you switch the source to GitHub actions.. Let's hope it's a rare issue. |
There is another issue I suppose: Take a look at this: https://instap-app.github.io/website-definition/ The assets are linked like My
|
Oh, well.. 😄 Those parameters belong inside of the defineConfig object, not outside of it. https://github.com/instap-app/website-definition/blob/master/astro.config.mjs#L9-L10 Try moving them and redeploy the page. |
Now it works! Thank you! This should be stated more clearly in the docs - I can do it. |
This was exactly my issue. This should also be mentioned in the docs, in case we're not hosting from the default branch |
What version of
astro
are you using?1.0.6
Are you using an SSR adapter? If so, which one?
None
What package manager are you using?
npm
What operating system are you using?
Mac
Describe the Bug
After step by step from https://docs.astro.build/en/guides/deploy/github/ - the Action says:
Link to Minimal Reproducible Example
https://github.com/instap-app/website-definition/actions/runs/2897989697
Participation
The text was updated successfully, but these errors were encountered: