Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Format on save issue #658

Closed
pgm-stevaelb opened this issue Sep 27, 2023 · 3 comments
Closed

🐛 BUG: Format on save issue #658

pgm-stevaelb opened this issue Sep 27, 2023 · 3 comments
Labels
needs investigation The cause of the issue is unknown and a deeper investigation is needed to fix it

Comments

@pgm-stevaelb
Copy link

Describe the Bug

I am getting a strange, caching looking bug, when I try to format on save. This is the setting I have in my VSCode which before made it so that the code gets formatted on save:

"[astro]": {
  "editor.defaultFormatter": "astro-build.astro-vscode"
},

For some reason, when I activate this code, and save when I just made the component, it formats back to that first save, every edit I do. When I disable that rule, it works, but my code isn't formatted on save and I have to manually format my code.

I have a link on the official Discord with a clip of what is happening: [https://discord.com/channels/830184174198718474/1155800328290177074/1156320306017882112](Discord link)

Steps to Reproduce

https://discord.com/channels/830184174198718474/1155800328290177074/1156320306017882112

@Princesseuh
Copy link
Member

Weird, never seen this before. Without a way to reproduce, it's hard to tell if the problem is in Prettier (the formatter we use internally), the way we call Prettier or something else.

@pgm-stevaelb
Copy link
Author

Weird, never seen this before. Without a way to reproduce, it's hard to tell if the problem is in Prettier (the formatter we use internally), the way we call Prettier or something else.

It's probably something like you say yes, do I need to share my config or something?

@Princesseuh Princesseuh added needs triage Issue needs to be triaged and removed bug labels Nov 12, 2023
@Princesseuh Princesseuh added needs investigation The cause of the issue is unknown and a deeper investigation is needed to fix it and removed needs triage Issue needs to be triaged labels Dec 28, 2023
@Princesseuh
Copy link
Member

Closing because I haven't had a single report of this in months, so I assume it got fixed in Volar 2.0. If this still happens, please open another issue (or mention it here)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation The cause of the issue is unknown and a deeper investigation is needed to fix it
Projects
None yet
Development

No branches or pull requests

2 participants