🐛 BUG: Widespread Intellisense Issues in Astro Projects in VS Code 1.91.0

[pjosxyz]

What version of @astrojs/language-server are you using?

2.10.0

What package manager are you using

Bun - Repo: astro-min-bun
Npm - Repo: astro-min-npm
Bun: 1.1.13 / NPM: 10.7.0 / Node 20.15.0 (all WSL)

What operating system are you using

Windows10 + WSL2 (2.2.4.0) (Ubuntu 20.04.6 LTS)
(Same issues in Windows10 with Bun and NPM)

VSCode Version

1.91.0

Describe the bug

Intellisense in Astro projects is inconsistent and often doesn't work in various scenarios. The behavior seems to vary between different package managers and even within the same project.

Issues observed

Interpolating values in HTML
Intellisense not working

astro-var-intellisense-interpolate-not-working.mp4

Auto imports
Not auto-completing/importing

astro-auto-import-component.mp4

Auto finish imports in frontmatter
Inconsistent behaviour

astro-import.mp4

Seems to be quite variable in what wants to work and what doesn't, for instance:

Inconsistent behavior between Bun and NPM

• In Bun: Doesn't recognize Astro components but provides correct methods
  https://github.com/withastro/language-tools/assets/122515043/c4c84166-8729-445e-aa08-420dc42b594e

• In NPM: Recognizes Astro components but doesn't provide methods

astro-npm-is.mp4

You can see in the video above that "prop1" doesn't get intellisense for string methods. It does in the Bun repo, but fwiw last night in a project I had started with Bun I wasn't getting intellisense so the issue seems to happen ... randomly, or feels like it does at least!

Intellisense for props
Untyped: No intellisense

astro-props.mp4

Typed: Inconsistent intellisense

astro-props-typed.mp4

Steps to Reproduce

1. Create a new Astro project: npm create astro@latest or bun create astro@latest using the 'Empty' template
2. Create some components and try to use variables
3. Attempt to import components
4. Observe inconsistent or non-functional intellisense

Additional Notes

The issue seems to occur randomly, making it difficult to pinpoint the exact conditions

For comparison, intellisense works correctly in Next.js projects with the same VSCode/Node/Bun/WSL setup

next-var-intellisense-interpolate-working.mp4

next-auto-import.mp4

Long time lurker, first time Issue creator... If there's details I've missed or rules I've broken let me know 😃. Thanks!

[Princesseuh]

There's seems to be a VS Code regression affecting many users in the latest version of VS Code, not too sure what's going on.

Some upstream issues:
microsoft/vscode#219990
microsoft/vscode#220082

[pjosxyz]

Downgrading VSCode to 1.90.2 and intellisense is working.

[Princesseuh]

Let's keep it open for other people to see

[hkbertoson]

Version: 1.90.2
Commit: 5437499feb04f7a586f677b155b039bc2b3669eb
Date: 2024-06-18T22:54:35.075Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

This is my VSCode Version and it doesnt seem to be working for me.

[gavagavas]

@pjosxyz
Nice to meet you.
Don't you need to downgrade to 1.89 for it to work properly?
Sorry if I'm mistaken.

[Princesseuh]

Version: 1.90.2 Commit: 5437499feb04f7a586f677b155b039bc2b3669eb Date: 2024-06-18T22:54:35.075Z Electron: 29.4.0 ElectronBuildId: 9728852 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin arm64 23.5.0

This is my VSCode Version and it doesnt seem to be working for me.

Does this happen for every component? For Image it's unfortunately normal, because a global Image exists, so TypeScript doesn't consider that you might be missing an import.

[Princesseuh]

#879 seems to fix the issue for me locally.

[Princesseuh]

I confirm that this is now fixed in the latest version of the extension. Apologies for the inconvenience.

I will note that this issue was purely dedicated to the regression in VS Code's latest version - I'm sure there's still issues with auto import that exists. Most of which are related to withastro/compiler#862, or #800 or other existing issues.

I will be closing this issue as this precise issue is fixed - but understand that other issues related to auto-imports are also being looked at.