Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Code> doesn't support passing a meta string to Shiki #990

Closed
1 task done
jcayzac opened this issue Aug 3, 2024 · 2 comments · Fixed by withastro/astro#11605
Closed
1 task done

<Code> doesn't support passing a meta string to Shiki #990

jcayzac opened this issue Aug 3, 2024 · 2 comments · Fixed by withastro/astro#11605

Comments

@jcayzac
Copy link

jcayzac commented Aug 3, 2024

Astro Info

Astro                    v4.12.2
Node                     v20.15.1
System                   macOS (arm64)
Package Manager          unknown
Output                   static
Adapter                  none
Integrations             astro-icon
                         @astrojs/preact
                         @astrojs/mdx
                         @astrojs/sitemap

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

<Code> doesn't support passing a meta string to Shiki's highlighter, breaking the functionality of multiple shiki transformers.

What's the expected result?

<Code> should support passing a meta string to Shiki's highlighter and not break the functionality of multiple shiki transformers.

Link to Minimal Reproducible Example

https://astro.build/

Participation

  • I am willing to submit a pull request for this issue.
@jcayzac
Copy link
Author

jcayzac commented Aug 3, 2024

I'll send a PR.

@Princesseuh
Copy link
Member

Thank you for the PR, I'll just move this issue to a roadmap discussion, since it's more of a feature request (and it'll be closed anyway in the next minor, thanks to your PR)

@Princesseuh Princesseuh transferred this issue from withastro/astro Aug 8, 2024
@github-project-automation github-project-automation bot moved this to Stage 2: Accepted Proposals, No RFC in Public Roadmap Aug 8, 2024
@withastro withastro locked and limited conversation to collaborators Aug 8, 2024
@Princesseuh Princesseuh converted this issue into discussion #991 Aug 8, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants