Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_getAbsolutePath() not compatible with expo #235

Closed
jackkinsella opened this issue Aug 16, 2017 · 3 comments
Closed

_getAbsolutePath() not compatible with expo #235

jackkinsella opened this issue Aug 16, 2017 · 3 comments

Comments

@jackkinsella
Copy link

jackkinsella commented Aug 16, 2017

In Device.js:

_getAbsolutePath(), which is used for loading the app binary, always assumes that the app is located in the current working directory. With react-native, this assumption is no longer true because of the now commonplace use of expo, which puts the binary down in ~/.expo. This isn't an issue with one programmer on a team, since they can type "../../../.expo" etc., but when sharing code between two programmers who have different file system structures, it becomes problematic.

@isnifer
Copy link
Contributor

isnifer commented Aug 16, 2017

Does expo allow you change application binary path? It's strange place to save binaries :)

@jackkinsella
Copy link
Author

I was surprised too. But then again, this single Expo install gets shared by all Expo-enabled React apps, so it would make even less sense to put them in individual project folders.

There is no mention of configuration on this point in their docs...

@LeoNatan
Copy link
Contributor

I think this was solved recently by @silyevsk for #98 .

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants