Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "reuse": true to configurations doesn't do anything #486

Closed
kdenz opened this issue Jan 3, 2018 · 3 comments
Closed

Adding "reuse": true to configurations doesn't do anything #486

kdenz opened this issue Jan 3, 2018 · 3 comments

Comments

@kdenz
Copy link

kdenz commented Jan 3, 2018

  • Detox: 6.0.4
  • Node: 8.5
  • Device: iOS 11.2
  • Xcode: 9.2
  • macOS: 10.13.1

I'm using Jest

According to @dariocavero in #143 (comment) , it's possible to add "reuse" under detox's config like this:
image

My scripts in package.json
image

My init.js under e2e folder
image

My config.json under e2e folder
image

But it's not working, in the end I'll need to use detox test -r to make reuse work.

The reason I would prefer not using detox test is because it seems like detox test doesn't support flexible optional testing, such as if I just want to test the Welcome screen and not others. I can do this with jest WelcomeScreen. And also the unit and e2e tests can easily be chained together.

@rotemmiz
Copy link
Member

rotemmiz commented Jan 8, 2018

This can be a welcome PR
https://github.com/wix/detox/blob/master/detox/src/devices/Device.js#L26

You'll need to also check if the app is installed on the device, and if not, throw an error

@stale
Copy link

stale bot commented Mar 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.
Thank you for your contributions.

@stale stale bot added the 🏚 stale label Mar 7, 2018
@stale
Copy link

stale bot commented Mar 14, 2018

The issue has been closed for inactivity.

@stale stale bot closed this as completed Mar 14, 2018
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants