Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect simulator stdout to runner stdout in --verbose mode. #72

Closed
DanielZlotin opened this issue Jan 4, 2017 · 13 comments
Closed

Redirect simulator stdout to runner stdout in --verbose mode. #72

DanielZlotin opened this issue Jan 4, 2017 · 13 comments

Comments

@DanielZlotin
Copy link
Contributor

Logging should be printed to the console or at the very least to some log file

@LeoNatan
Copy link
Contributor

Which logging do you mean? Simulator output? NSLog from inside the app?

@DanielZlotin
Copy link
Contributor Author

Let's start with all stdio. Just dump it somewhere for starters.

@DanielZlotin
Copy link
Contributor Author

I'm guessing we don't have logs from react because of #73 , but what about crash logs? I think even in release it should print something...

@LeoNatan
Copy link
Contributor

What does "somewhere" mean? Where did you use to get it until now?
Building React in release could be the reason console.log are not printed in stdout, however NSLog should work normally.

@DanielZlotin
Copy link
Contributor Author

Well we can send logs to the detox server and print it out to console/file if we have a --verbose flag for example...

@LeoNatan
Copy link
Contributor

Right now, --verbose is for a different purpose. I don't think it has ever been used to route simulator stdout, but I could be wrong. In the past, where did you see the stdout output?

@DanielZlotin
Copy link
Contributor Author

don't know

@LeoNatan LeoNatan changed the title Logging in verbose do not work Redirect simulator stdout to runner stdout in --verbose mode. Jan 10, 2017
@talkol
Copy link

talkol commented Jan 10, 2017

this was working

we had to implement it to debug issues with detox on One App in the CI in detox version 3.x

when the tests were failing or the app was crashing we added the output of the simulator to detox so it will appear in the build log and we could debug what went wrong inside the app

@LeoNatan
Copy link
Contributor

Where was the output redirected to?

@LeoNatan
Copy link
Contributor

stdout of fbsimctl?

@talkol
Copy link

talkol commented Jan 10, 2017

this was a very long time ago so I don't fully remember, but pretty sure this was the commit:

a02ea22

@LeoNatan
Copy link
Contributor

Interesting. There haven't been made changes to simulator.js for those flows, so they could be broken due to extraneous factors. Detox 3.x has not been tested on modern development environment (Xcode 8, Sierra).

@LeoNatan
Copy link
Contributor

LeoNatan commented Mar 5, 2017

@rotemmiz I think we can close this, right? The tail command can be routed to Detox output or to some file in output dir?

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants