Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Take a screenshot #93

Closed
padupuy opened this issue Mar 5, 2017 · 6 comments
Closed

[feature] Take a screenshot #93

padupuy opened this issue Mar 5, 2017 · 6 comments

Comments

@padupuy
Copy link

padupuy commented Mar 5, 2017

Hello,
Is there an easy way to take a screenshot with detox ?
With Appium and wd it's really easy https://github.com/appetizeio/appium-samples/blob/master/node.js/ios-basic.js#L60
I really think its a key feature, most of the time when a test failed, it's easier and faster to see the last screenshot to understand why instead of look at the logs.

@rotemmiz
Copy link
Member

rotemmiz commented Mar 5, 2017

Hey @padupuy ,

That's actually in our roadmap, alongside video recordings and log dumps.

@padupuy
Copy link
Author

padupuy commented Mar 6, 2017

Thanks for the feedback and for the work, Detox is really promising !

@rotemmiz
Copy link
Member

@padupuy , what do you think about the summary in #171 ?
We have to add failed test artifacts, but I'm not sure screenshots are the right solution.

@padupuy
Copy link
Author

padupuy commented Jun 22, 2017

Screenshots could be used to test visual regression.
Video of the failure test will be for sure a time-saving killer !

@LeoNatan
Copy link
Contributor

We plan to add these features as part of #171 and progress will be tracked there. Closing this one for now.

@markhu
Copy link

markhu commented Apr 27, 2018

Note for posterity: Issue #171 is still Open unresolved as of April 2018.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants