Stop transpiling detox and detox-server, use sources and require node >=7.6

[mrtnrst]

Overview

Remove deprecated package and updated to latest suggest package per Babel docs.

Discussion

I was noticing errors with a project that was not importing babel-preset-latest as a dev dependency. Rather than importing deprecated code I went ahead and updated to current logic.

Example:

detox test

would return
Couldn't find preset "latest" relative to directory "/Users/arista/***/node_modules/detox"

[dferguson08]

🙏 Really need this 🙏 Nice find/fix, @mrtnrst

[rotemmiz]

What version of node do you guys use?
I am thinking of dropping Babel altogether, node 7.6 handles detox and async await with no need to transpile any code.

[mrtnrst]

We are currently using v8.6 LTS. I thought for legacy support but unsure how far back you wanted to go.

[rotemmiz]

263 days since Node 7.6 was released. Good time to say bye to Babel :)

[mrtnrst]

I can open another PR to remove Babel if you aren't on it already. 🙇

[rotemmiz]

yes, please do 🤗

[mrtnrst]

@rotemmiz I removed the extra babel packages but kept the build. Also added a min version for node engines which will introduce a breaking change, let me know your thoughts.

[rotemmiz]

This is not enough, I want to remove all trace of babel.

1. remove babel in deps
2. remove babel in builds (detox/build.sh, detox-server npm run build)
3. change package.json main in both from lib/index.js to src/index.js

[rotemmiz]

🤗

[rotemmiz]

we can drop build script altogether

[rotemmiz]

drop the echo

[brunolemos]

Any quick way to point the package.json to this pull request?
Tried "detox": "wix/detox#404/head", but it gives an error Package "undefined@undefined" doesn't have a "name". because detox uses lerna and the root package.json is not the package I want.

[rotemmiz]

hey @mrtnrst , any updates on your side ? If you need any help, please ping me.

[mrtnrst]

@rotemmiz sorry I've had a busy week. Going to spend some time later today to try and get the CI issues resolved.

[mrtnrst]

@rotemmiz so this was a lot easier than I originally thought! I just have to pay closer attention to my changes. 😁 🎉

[brunolemos]

Tested the PR, it works if I run npm run e2e:ios inside the detox/test folder.

But when testing on a an empty react-native project with detox and it says this:
Couldn't find preset "es2015" relative to directory "/Users/brunolemos/Projects/react-native-css-in-js-benchmarks/node_modules/detox/node_modules/child-process-promise"

PS: It's probably because I'm using yarn link though.

EDIT: After running yarn inside the child-process-promise folder it works.

[rotemmiz]

@mrtnrst , one last thing, in order to really test it works, let's point the test project to use Detox from main and not specifically from source.
https://github.com/wix/detox/blob/master/detox/test/e2e/init.js

change:

const detox = require('../../src/index');

to

const detox = require('detox');

Then, if it passes CI, we're good.

[rotemmiz]

Thanks ! 🙏