Generation: Move DetoxAction invocations to generated code #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this I had to add some mechanisms to allow sanitizers to work with function names and arguments instead of only with types as before. Also some more types were enabled.
DanielMSchmidt
force-pushed
the
generation-for-DetoxAction
branch
from
f1e1cfa
to
e803911
Compare
DanielMSchmidt
changed the title
|
Looks great, I just need you to make sure it doesn't break Android e2e, and since we still can't run it in CI please make sure it runs locally . When done mention it here and I'll merge |
|
@rotemmiz tested locally with result ✅ 66 passing (3m)
4 pending |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this I had to add some mechanisms to allow
sanitizers to work with function names and arguments
instead of only with types as before.
Also some more types were enabled.