Generation: combining and string matchers for android #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
generation/combining-matchers
branch
3 times, most recently
from
d499a76
to
f3e83b5
Compare
|
This PR is not ready yet, somehow the matchers don't get passed on, working on that :) |
DanielMSchmidt
changed the title
|
Currently failing due to Still working on this, but I have no idea 🤔 |
DanielMSchmidt
force-pushed
the
generation/combining-matchers
branch
from
0e8d75d
to
f1f872a
Compare
|
I got a clue why this PR is still not working, but I am not fully through it. Currently comparing before and after states a lot to see where I might be wrong, this is unfortunately a bit time consuming 🤔 |
DanielMSchmidt
force-pushed
the
generation/combining-matchers
branch
from
8669d9f
to
91b3282
Compare
DanielMSchmidt
changed the title
|
@rotemmiz This works now ✅ |
DanielMSchmidt
force-pushed
the
generation/combining-matchers
branch
from
91b3282
to
6783520
Compare
Besides that also strings are now send unwrapped, as in the unchanged code before
DanielMSchmidt
force-pushed
the
generation/combining-matchers
branch
from
6783520
to
f17cb67
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@rotemmiz could you review this? |
# Conflicts: # detox/test/package.json
rotemmiz
approved these changes
Mar 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to move the combining matchers (and, or, not, etc) to the generated code.
On my machine the tests pass, would love for anyone to verify.