Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website build only run on master #544

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jan 28, 2018

This fixes #542

@DanielMSchmidt DanielMSchmidt force-pushed the website/debug-website-build branch 3 times, most recently from 6f19904 to 0080063 Compare January 28, 2018 20:37
@rotemmiz
Copy link
Member

Do you actually know if this works ? or do we need to TDD (Travis Driven Development) ?

@DanielMSchmidt DanielMSchmidt force-pushed the website/debug-website-build branch 2 times, most recently from 9994999 to 28a23dd Compare January 29, 2018 22:31
@DanielMSchmidt
Copy link
Contributor Author

I debugged it on my travis 🙈 should be more careful in the future, the last thing was more of a best guess according to the docs

@DanielMSchmidt DanielMSchmidt merged commit f3b7694 into master Feb 6, 2018
@DanielMSchmidt DanielMSchmidt deleted the website/debug-website-build branch February 6, 2018 19:10
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix doc generation to only run from master
2 participants