Docs: Use jest.setTimeout instead of jasmine timeout #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since jest@20 or so [jest.setTimeout](https://facebook.github.io/jest/docs/en/jest-object.html#jestsettimeouttimeout) is available, instead of jasmine-specific timeout constant.
|
Can you please rebase the branch (or master into it), I want to make sure everything is green on Travis |
|
The build failure is unrelated, but we can wait until you resolve that, no rush :) |
|
builds are green again, please rebase your PR. |
rotemmiz
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
jasmine.DEFAULT_TIMEOUT_INTERVALwithjest.setTimeout()in Jest Guide.Since jest@20 or so jest.setTimeout is available, instead of jasmine-specific timeout constant. I think it's worth using official APIs when available.