Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump requirements to Node 8.x and activate minimal eslint configuration #722

Merged
merged 1 commit into from
May 12, 2018
Merged

Bump requirements to Node 8.x and activate minimal eslint configuration #722

merged 1 commit into from
May 12, 2018

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented May 10, 2018 •
edited
Loading

Continuation of #711 ...

/cc @DanielMSchmidt

@rotemmiz
Copy link
Member

We should be more explicit in the engines section. spread operator works from node@8.3.0, not 8.0.0.
ON the other hand, the docs should state lower than 8.11, 8.3.0 is enough.

@rotemmiz
Copy link
Member

Unless there's something else I'm missng

@rotemmiz rotemmiz merged commit 62da778 into master May 12, 2018
@noomorph noomorph deleted the build/minimal-eslint branch May 26, 2018 18:51
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rotemmiz rotemmiz rotemmiz approved these changes

@DanielMSchmidt DanielMSchmidt Awaiting requested review from DanielMSchmidt

@LeoNatan LeoNatan Awaiting requested review from LeoNatan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noomorph @rotemmiz