Move iOS Device rotation to generated code #727
Conversation
rotemmiz
changed the title
DanielMSchmidt
force-pushed
the
danielmschmidt/ios-driver-to-generated-code
branch
from
dd0fdb4
to
7210b3f
Compare
|
|
||
| function sanitize_uiDeviceOrientation(value) { | ||
| const orientationMapping = { | ||
| landscape: 3, // top at left side landscape |
There was a problem hiding this comment.
Any reason why not expose all options?
There was a problem hiding this comment.
It's just a refactoring, I would rather improve the situation a different PR :)
There was a problem hiding this comment.
We could create an issue, it's probably a very good first issue 🤔
There was a problem hiding this comment.
I don’t understand. We have no usage of Earl Grey rotation so far. If this PR introduces it, why do we need additional issues or PRs?
There was a problem hiding this comment.
We have and this is the actual mapping we are currently using: https://github.com/wix/detox/blob/master/detox/src/devices/IosDriver.js#L59-L62
There was a problem hiding this comment.
It was my first bigger PR in detox 😻
There was a problem hiding this comment.
Eh I confused rotate with shake.
In either case, what blocks the full enum being exposed here?
There was a problem hiding this comment.
Not much, I just would like to first transfer it and afterwards add the new cases. That way I surely don't touch tests and refactorings in one PR
DanielMSchmidt
changed the title
DanielMSchmidt
force-pushed
the
danielmschmidt/ios-driver-to-generated-code
branch
from
7210b3f
to
f030712
Compare
We currently don't support them anyways, therefore we can just leave them out
DanielMSchmidt
force-pushed
the
danielmschmidt/ios-driver-to-generated-code
branch
from
f030712
to
d52fd53
Compare
DanielMSchmidt
changed the title
No description provided.