Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6 iOS] waitForRender on SetRoot doesn't work with a SideMenu #6000

Closed
RomualdPercereau opened this issue Mar 5, 2020 · 4 comments · Fixed by #6695
Closed

[v6 iOS] waitForRender on SetRoot doesn't work with a SideMenu #6000

RomualdPercereau opened this issue Mar 5, 2020 · 4 comments · Fixed by #6695

Comments

@RomualdPercereau
Copy link
Contributor

RomualdPercereau commented Mar 5, 2020

Issue Description

Using the waitForRender option with a SideMenu doesn't work.

Steps to Reproduce / Code Snippets / Screenshots

This will blink :

  Navigation.setDefaultOptions({
    animations: {
      setRoot: {
        waitForRender: true
      }
    }
  })
  Navigation.setRoot({
    root: {
      sideMenu: {
        left: {
          component: {
            name: "av.MenuContainer"
          }
        },
        center: {
          stack: {
            id: "k",
            children: [
              {
                component: {
                  name: "av.NavBarContainer",
                  passProps: {}
                }
              }
            ]
          }
        }
      }
    }
  })

This will NOT blink :

  Navigation.setDefaultOptions({
    animations: {
      setRoot: {
        waitForRender: true
      }
    }
  })
  Navigation.setRoot({
    root: {
      stack: {
        id: "k",
        children: [
          {
            component: {
              name: "av.NavBarContainer",
              passProps: {}
            }
          }
        ]
      }
    }
  })

ezgif-7-60cda80e32c3

Environment

  • React Native Navigation version: FILL 6.0.1
  • React Native version: 0.61.5
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Tested on iOS 9, iOS13 Debug and release
@didrikkvanvik
Copy link

didrikkvanvik commented Mar 24, 2020

I am experiencing the same issue with bottomtabs also. Any progress on this issue?

@AnthonyAkentiev
Copy link

@guyca Please fix this as we are experiencing same... Thx!

@danilobuerger
Copy link
Collaborator

@didrikkvanvik bottomtabs should be fixed by #6689

@danilobuerger
Copy link
Collaborator

Should be fixed in 7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants